fix(argo-cd): Update documentation for credentialTemplates

[bartcode]

According to this, the key for a GitHub app secret should be githubAppPrivateKeySecret. Hence a small change to the values.yaml documentation.

Do I have to bump the chart version and add something to the changelog for this? This isn't quite a change to the chart itself.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

[mbevc1]

Thanks for your contribution. Yeah, could you please bump the version and update changelog please?

[bartcode]

Thanks for your contribution. Yeah, could you please bump the version and update changelog please?

Could you check again?

[mbevc1]

Looks good, coule you also please signoff your commits as well?

[bartcode]

Done!

[mbevc1]

@bartcode I've had a quick look upstream and seems GH creds correct value is githubAppPrivateKey. Where did you find githubAppPrivateKeySecret is used? 🤔

https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-repo-creds.yaml

[bartcode]

@mbevc1 , good catch, I was just about to send a message. Though I'm slightly confused about this, indeed, the documentation was correct. Sorry. :/

[mbevc1]

No worries :)