Update argo-cd to reflect new 1.2.0 deployment (#101) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the chart to the new deployment requirements of the 1.2.0 release. This involves the following changes: - UI init sidecar removed as no longer required for server - Application-controller metrics service moved to it's own yaml - Server metrics service created - CRDs updated - ConfigMap `app.kubernetes.io/part-of` locked to argocd as it is static - Chart version and application version bump
This addresses an issue where repeatedly applying the same Helm chart will cause the existing data in the secret argocd-secret. This helps with issue (#99) but will still impact data if any of the three webhook configs are provided.
|
|
This commit adds a README.md with some basic docs pulled from the values.yaml. It also contains a small quality of life improvement for making the argocd-secret optional so operators can manage their secrets externally.
alexec
approved these changes
Sep 6, 2019
|
Good stuff. @seanson - we're looking for a maintainer for these charts. Could you be interested? |
nouseforaname
pushed a commit
to nouseforaname/argo-helm
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
This updates the chart to the new deployment requirements of the 1.2.0
release. This involves the following changes:
app.kubernetes.io/part-oflocked to argocd as it is staticAlso contains a small fix to help with #99