Skip to content

Conversation

tombojer
Copy link
Contributor

Checklist:


This pull request adds NATS authentication to the NATS trigger.

The implementation is similar to #1052 and
https://github.com/argoproj/argo-events/blob/master/pkg/eventsources/sources/nats/start.go#L77 .

Signed-off-by: Tom Bojer <t.bojer@shopware.com>
@tombojer tombojer marked this pull request as ready for review February 13, 2025 12:19
@tombojer tombojer requested a review from whynowy as a code owner February 13, 2025 12:19
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy merged commit 31326ec into argoproj:master Feb 24, 2025
7 checks passed
whynowy pushed a commit that referenced this pull request Apr 6, 2025
Signed-off-by: Tom Bojer <t.bojer@shopware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants