-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jestream configurable DiscardNew policies #3151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talebzeghmi
force-pushed
the
feat/discard-new
branch
from
June 9, 2024 04:34
9da64f3
to
2949983
Compare
whynowy
reviewed
Jun 10, 2024
talebzeghmi
force-pushed
the
feat/discard-new
branch
2 times, most recently
from
June 20, 2024 16:45
d6b6fd3
to
481816d
Compare
whynowy
reviewed
Jun 27, 2024
talebzeghmi
force-pushed
the
feat/discard-new
branch
4 times, most recently
from
June 29, 2024 16:04
2fcebfe
to
4044d6f
Compare
whynowy
reviewed
Jul 9, 2024
Signed-off-by: Taleb Zeghmi <talebz@zillowgroup.com>
Signed-off-by: Taleb Zeghmi <talebz@zillowgroup.com>
Signed-off-by: Taleb Zeghmi <talebz@zillowgroup.com>
Signed-off-by: Taleb Zeghmi <talebz@zillowgroup.com>
Signed-off-by: Taleb Zeghmi <talebz@zillowgroup.com>
talebzeghmi
force-pushed
the
feat/discard-new
branch
from
July 10, 2024 08:41
6990580
to
72bc1c6
Compare
whynowy
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Allow Configurable Retention and Discard Policies for Jetstream EventBus #3150.
Checklist: