Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a possible crash when parsing RBAC #8165

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jan 13, 2022

PR fixes a possible crash when parsing invalid RBAC policies.

OSS-Fuzz: https://oss-fuzz.com/testcase-detail/6266304514883584

/cc @terrytangyuan @AdamKorcz @hblixt

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis added the fuzzing Bugs detected by fuzzer label Jan 13, 2022
@jannfis jannfis requested a review from alexmt January 13, 2022 14:52
@AdamKorcz
Copy link

For info @DavidKorczynski

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #8165 (72e5df8) into master (5e6aee5) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #8165    +/-   ##
========================================
  Coverage   41.52%   41.53%            
========================================
  Files         174      174            
  Lines       22755    22629   -126     
========================================
- Hits         9450     9399    -51     
+ Misses      11961    11897    -64     
+ Partials     1344     1333    -11     
Impacted Files Coverage Δ
util/rbac/rbac.go 76.47% <50.00%> (-0.03%) ⬇️
server/application/application.go 31.20% <0.00%> (-1.45%) ⬇️
reposerver/repository/repository.go 57.80% <0.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6aee5...72e5df8. Read the comment docs.

@jannfis jannfis merged commit 5c85df9 into argoproj:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Bugs detected by fuzzer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants