Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Wehkamp as an ArgoCD user #7589

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Added Wehkamp as an ArgoCD user #7589

merged 2 commits into from
Nov 1, 2021

Conversation

johnkeates
Copy link
Contributor

@johnkeates johnkeates commented Nov 1, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Add Wehkamp as a argocd user.
Update USERS.md

Signed-off-by: John Keates <john@keates.nl>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@johnkeates
Copy link
Contributor Author

I'm currently still figuring out how the company logo is referred, I think our PR/media departments has some official SVG/PNG for this.

@alexmt
Copy link
Collaborator

alexmt commented Nov 1, 2021

You can add a custom logo/description by adding a new folder here: https://github.com/argoproj/argo-site/tree/master/content/members

@johnkeates
Copy link
Contributor Author

Thanks! I'll fork and PR that one as well.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #7589 (0de7354) into master (7a6b2ff) will increase coverage by 41.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7589       +/-   ##
===========================================
+ Coverage        0   41.37%   +41.37%     
===========================================
  Files           0      161      +161     
  Lines           0    21682    +21682     
===========================================
+ Hits            0     8970     +8970     
- Misses          0    11446    +11446     
- Partials        0     1266     +1266     
Impacted Files Coverage Δ
util/cache/appstate/cache.go 62.50% <0.00%> (ø)
util/argo/audit_logger.go 95.65% <0.00%> (ø)
server/repository/repository.go 36.14% <0.00%> (ø)
util/git/workaround.go 46.87% <0.00%> (ø)
cmd/argocd/commands/admin/repo.go 0.00% <0.00%> (ø)
cmd/argocd/commands/project_role.go 0.00% <0.00%> (ø)
controller/sort_delete.go 100.00% <0.00%> (ø)
controller/metrics/metrics.go 79.86% <0.00%> (ø)
util/clusterauth/clusterauth.go 66.82% <0.00%> (ø)
controller/state.go 68.02% <0.00%> (ø)
... and 151 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6b2ff...0de7354. Read the comment docs.

@alexmt alexmt merged commit 8b10b64 into argoproj:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants