Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade k8s client to v0.21.0 #6322

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented May 26, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

PR ugprades k8s client to v0.21.0

@alexmt alexmt requested a review from jannfis May 26, 2021 00:50
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #6322 (8855413) into master (5fd7ffd) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6322   +/-   ##
=======================================
  Coverage   41.02%   41.02%           
=======================================
  Files         151      151           
  Lines       19953    19954    +1     
=======================================
+ Hits         8186     8187    +1     
  Misses      10639    10639           
  Partials     1128     1128           
Impacted Files Coverage Δ
cmd/argocd/commands/account.go 0.00% <0.00%> (ø)
controller/sync.go 65.15% <100.00%> (+0.26%) ⬆️
util/settings/settings.go 46.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fd7ffd...8855413. Read the comment docs.

@alexmt alexmt force-pushed the upgrade-k8s branch 3 times, most recently from 15fcc6a to e629493 Compare May 27, 2021 03:31
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt merged commit 3604a58 into argoproj:master May 27, 2021
@alexmt alexmt deleted the upgrade-k8s branch May 27, 2021 17:22
@alexmt alexmt self-assigned this Jul 28, 2021
@alexmt alexmt added the needs-verification PR requires pre-release verification label Jul 28, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants