Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements to keyboard navigation #5825

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

reginapizza
Copy link
Contributor

@reginapizza reginapizza commented Mar 19, 2021

Related to #5466 (doesn't fix it entirely but works towards solving it)
This would allow the user to tab through the nav bar and changes the login button to an actual button that the user can tab to.

Also incorporates changes in argo-ui including my PR for more visual focus.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
demo-focus-keyboard-nav.mp4

@reginapizza reginapizza force-pushed the keyboardNavigation branch 2 times, most recently from 36602b3 to 1bb0e68 Compare March 22, 2021 13:57
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #5825 (759bcc6) into master (2f785cd) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5825      +/-   ##
==========================================
- Coverage   40.91%   40.89%   -0.03%     
==========================================
  Files         147      147              
  Lines       19620    19633      +13     
==========================================
+ Hits         8027     8028       +1     
- Misses      10489    10500      +11     
- Partials     1104     1105       +1     
Impacted Files Coverage Δ
util/helm/helm.go 55.71% <0.00%> (-9.81%) ⬇️
controller/state.go 69.15% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f785cd...759bcc6. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in review.
I think package.json and yarn.lock files were added by mistake .

Please remove them and run yarn add git+https://github.com/argoproj/argo-ui.git in ui directory, not the root directory.

@reginapizza
Copy link
Contributor Author

@alexmt my bad, I've fixed it now!

Signed-off-by: Regina Scott <rescott@redhat.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit 11c730c into argoproj:master Mar 30, 2021
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Regina Scott <rescott@redhat.com>
kshamajain99 pushed a commit to kshamajain99/argo-cd that referenced this pull request Apr 16, 2021
Signed-off-by: Regina Scott <rescott@redhat.com>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@jgwest jgwest removed the needs-verification PR requires pre-release verification label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants