-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improvements to keyboard navigation #5825
Conversation
36602b3
to
1bb0e68
Compare
Codecov Report
@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
- Coverage 40.91% 40.89% -0.03%
==========================================
Files 147 147
Lines 19620 19633 +13
==========================================
+ Hits 8027 8028 +1
- Misses 10489 10500 +11
- Partials 1104 1105 +1
Continue to review full report at Codecov.
|
9abf33e
to
d121bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in review.
I think package.json and yarn.lock files were added by mistake .
Please remove them and run yarn add git+https://github.com/argoproj/argo-ui.git
in ui
directory, not the root directory.
d121bb3
to
92eb232
Compare
@alexmt my bad, I've fixed it now! |
Signed-off-by: Regina Scott <rescott@redhat.com>
92eb232
to
759bcc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Regina Scott <rescott@redhat.com>
Signed-off-by: Regina Scott <rescott@redhat.com>
Related to #5466 (doesn't fix it entirely but works towards solving it)
This would allow the user to tab through the nav bar and changes the login button to an actual button that the user can tab to.
Also incorporates changes in argo-ui including my PR for more visual focus.
Checklist:
demo-focus-keyboard-nav.mp4