Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade Redis to v6.2.1 #5701

Merged
merged 6 commits into from
Mar 7, 2021
Merged

feat: Upgrade Redis to v6.2.1 #5701

merged 6 commits into from
Mar 7, 2021

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Mar 6, 2021 •
edited
Loading

Fixes #4768

  • Upgrade Redis to v6.2.1
  • Upgrade redis-ha chart to 4.12.9
  • Upgrade HAProxy used by redis-ha to 2.0.20

I have made some preliminary upgrade tests for the HA version on a test cluster, which went without any problems.

If you're running a Kustomize build with a base ref of HEAD, you can simply test by pointing your base to https://github.com/jannfis/argo-cd/manifests/ha/cluster-install?ref=fix/redis-6-upgrade

Signed-off-by: jannfis jann@mistrust.net

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

jannfis added 2 commits March 6, 2021 17:02
@jannfis
feat: Upgrade Redis to v6
f20880e 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis
Preload correct Redis image in CI
6dc00b5 
Signed-off-by: jannfis <jann@mistrust.net>
@codecov-io
Copy link

codecov-io commented Mar 6, 2021 •
edited
Loading

Codecov Report

Merging #5701 (c057683) into master (c0985fb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5701      +/-   ##
==========================================
- Coverage   40.96%   40.96%   -0.01%     
==========================================
  Files         144      144              
  Lines       19395    19398       +3     
==========================================
+ Hits         7945     7946       +1     
- Misses      10339    10340       +1     
- Partials     1111     1112       +1
Impacted Files Coverage Δ
server/logout/logout.go 73.07% <0.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0985fb...c057683. Read the comment docs.

jannfis added 2 commits March 6, 2021 18:19
@jannfis
Fix labels on StatefulSet and Deployment
6ba9be9 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis
Update redis to 6.2.1 and haproxy to 2.0.20
7b8774e 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis changed the title feat: Upgrade Redis to v6.0.7 feat: Upgrade Redis to v6.2.1 Mar 6, 2021
@jannfis
More 6.0.7 -> 6.2.1 updates
77ec171 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis marked this pull request as ready for review March 6, 2021 18:03
@jannfis jannfis requested review from jessesuen and alexmt March 6, 2021 18:03
alexmt
alexmt approved these changes Mar 7, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hack/installers/install-codegen-tools.sh
KUSTOMIZE_VERSION=3.9.4 "$(dirname $0)/../install.sh" helm2-linux jq-linux kustomize-linux protoc-linux swagger-linux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you

@jannfis
Fix antiAffinity selectors
c057683 
Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis merged commit 90602a7 into argoproj:master Mar 7, 2021
@sbose78 sbose78 mentioned this pull request Apr 1, 2021
Closed
7 tasks
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@jannfis @Shubhama19
feat: Upgrade Redis to v6.2.1 (argoproj#5701)
163be07 
* feat: Upgrade Redis to v6

Signed-off-by: jannfis <jann@mistrust.net>

* Preload correct Redis image in CI

Signed-off-by: jannfis <jann@mistrust.net>

* Fix labels on StatefulSet and Deployment

Signed-off-by: jannfis <jann@mistrust.net>

* Update redis to 6.2.1 and haproxy to 2.0.20

Signed-off-by: jannfis <jann@mistrust.net>

* More 6.0.7 -> 6.2.1 updates

Signed-off-by: jannfis <jann@mistrust.net>

* Fix antiAffinity selectors

Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update redis to v6 and refresh downstream redis-ha to latest version
3 participants
@jannfis @codecov-io @alexmt