-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Various minor UI fixes #5337
Conversation
…fix argoproj#5328, fix argoproj#5327, fix argoproj#5324 Signed-off-by: Remington Breeze <remington@breeze.software>
ui/src/app/shared/components/version-info/version-info-panel.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
Codecov Report
@@ Coverage Diff @@
## master #5337 +/- ##
=======================================
Coverage 41.01% 41.01%
=======================================
Files 136 136
Lines 18449 18449
=======================================
Hits 7566 7566
Misses 9802 9802
Partials 1081 1081 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rbreeze: Can you please remove the issue from the description that you dropped per #5337 (comment)? Sorry about that. I've updated the description of that issue to match its updated description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
Sadly, while I can more or less read the code, it's much easier for me to work from live previews (that's a feature we really want our ArgoCD to manage for our own software...).
Signed-off-by: Remington Breeze <remington@breeze.software>
Fix #5329, fix #5328, fix #5327, fix #5324
Signed-off-by: Remington Breeze remington@breeze.software
Checklist: