Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Various minor UI fixes #5337

Merged
merged 5 commits into from
Jan 28, 2021
Merged

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jan 27, 2021

Fix #5329, fix #5328, fix #5327, fix #5324

Signed-off-by: Remington Breeze remington@breeze.software

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).

…fix argoproj#5328, fix argoproj#5327, fix argoproj#5324

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested review from jsoref and alexmt January 27, 2021 19:18
@rbreeze rbreeze added the only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review label Jan 27, 2021
Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Remington Breeze <remington@breeze.software>
@codecov-io
Copy link

Codecov Report

Merging #5337 (39d82b7) into master (3967baf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5337   +/-   ##
=======================================
  Coverage   41.01%   41.01%           
=======================================
  Files         136      136           
  Lines       18449    18449           
=======================================
  Hits         7566     7566           
  Misses       9802     9802           
  Partials     1081     1081           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3967baf...39d82b7. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoref
Copy link
Member

jsoref commented Jan 28, 2021

@rbreeze: Can you please remove the issue from the description that you dropped per #5337 (comment)?

Sorry about that. I've updated the description of that issue to match its updated description.

Copy link
Member

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Sadly, while I can more or less read the code, it's much easier for me to work from live previews (that's a feature we really want our ArgoCD to manage for our own software...).

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze merged commit 076924d into argoproj:master Jan 28, 2021
@rbreeze rbreeze deleted the small-ui-fixes branch January 28, 2021 01:47
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
only-needs-a-rubber-stamp The author thinks this is low-risk & low-impact, so suggest a cursory review
Projects
None yet
5 participants