Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tooltips to sync result table (Bug #4234) #4310

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

tetchel
Copy link
Contributor

@tetchel tetchel commented Sep 11, 2020

Signed-off-by: Tim Etchells tetchell@redhat.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@tetchel tetchel marked this pull request as draft September 11, 2020 16:23
@tetchel tetchel force-pushed the addSyncResultHovers branch from eb8b56d to 0d97f84 Compare September 11, 2020 16:25
@tetchel tetchel changed the title Add tooltips to sync result table (Bug #4234) Fix: Add tooltips to sync result table (Bug #4234) Sep 11, 2020
@tetchel tetchel force-pushed the addSyncResultHovers branch 2 times, most recently from 690b2a1 to 31cd060 Compare September 11, 2020 16:29
@tetchel tetchel changed the title Fix: Add tooltips to sync result table (Bug #4234) fix: Add tooltips to sync result table (Bug #4234) Sep 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #4310 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4310      +/-   ##
==========================================
+ Coverage   42.77%   42.88%   +0.10%     
==========================================
  Files         124      124              
  Lines       18411    18411              
==========================================
+ Hits         7876     7895      +19     
+ Misses       9517     9494      -23     
- Partials     1018     1022       +4     
Impacted Files Coverage Δ
controller/appcontroller.go 51.17% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee234...54e66f4. Read the comment docs.

@tetchel tetchel force-pushed the addSyncResultHovers branch from 31cd060 to 223d70e Compare September 11, 2020 16:53
@tetchel tetchel marked this pull request as ready for review September 11, 2020 17:36
@tetchel tetchel force-pushed the addSyncResultHovers branch from 223d70e to f9b04ef Compare September 14, 2020 14:10
Bug argoproj#4234

Signed-off-by: Tim Etchells <tetchell@redhat.com>
@tetchel tetchel force-pushed the addSyncResultHovers branch from f9b04ef to 54e66f4 Compare September 14, 2020 14:16
@tetchel tetchel mentioned this pull request Sep 14, 2020
3 tasks
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @tetchel !

@alexmt alexmt merged commit 28a7635 into argoproj:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants