Skip to content

feat(ui): add skip schema validation toggle to Application parameters editor (#5111) - #28584

Open
somaz94 wants to merge 1 commit into
argoproj:masterfrom
somaz94:feat/ui-skip-schema-validation
Open

feat(ui): add skip schema validation toggle to Application parameters editor (#5111)#28584
somaz94 wants to merge 1 commit into
argoproj:masterfrom
somaz94:feat/ui-skip-schema-validation

Conversation

@somaz94

@somaz94 somaz94 commented Jul 6, 2026

Copy link
Copy Markdown

What / Why

Adds a Skip Schema Validation checkbox to the Application Parameters tab editor. When checked, saving parameter changes sends validate=false to the update API, skipping server-side schema validation — matching the existing argocd app set --validate=false CLI capability, which previously had no UI equivalent.

This speeds up common edits (e.g. bumping an image tag) as requested in #5111, where a maintainer confirmed the intent is a skip-validation toggle when editing parameters in the Parameters/Manifest tab (distinct from the sync-operation "Skip Schema Validation" option).

Scope: the single-source Parameters editor (the default for most apps). The multi-source source editor and the Manifest tab are left as follow-ups to keep this PR focused.

How

  • EditablePanel gains an opt-in showValidationToggle prop; when set it renders the checkbox in edit mode and forwards {validate: !skipValidation} to its save handler. All other consumers are unchanged (still send {}).
  • application-parameters.tsx enables the toggle on the parameters panel and forwards the query to the update call. The unchecked default sends validate=true, which the server treats identically to the previous no-param behavior (server/application/application.go defaults validate := true).

Closes #5111

Checklist

  • The title of the PR states what changed and the related issue number (used for the release note).
  • The title of the PR conforms to the Title of the PR convention.
  • I've included "Closes Add validate=false to ui #5111" in the description to automatically close the associated issue.
  • I've updated the UI to expose my feature; the CLI already supports --validate=false on argocd app set.
  • Does this PR require documentation updates? — UI-only toggle, no docs change needed.
  • I have signed off all my commits as required by DCO.
  • I have written unit tests for my change (editable-panel.test.tsx: toggle visibility + validate true/false forwarded on save).
  • My build is green — pnpm lint, pnpm test, and pnpm build all pass locally.
  • I have added a brief description of why this PR is necessary and what it solves.

@bunnyshell

bunnyshell Bot commented Jul 6, 2026

Copy link
Copy Markdown

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 698 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
argo-cd-ui-array-push 11.25MB 698 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: argo-cd-ui-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
main.*.js 698 bytes 3.72MB 0.02%

@somaz94
somaz94 marked this pull request as ready for review July 6, 2026 05:21
@somaz94
somaz94 requested review from a team as code owners July 6, 2026 05:21
… editor (argoproj#5111)

Signed-off-by: somaz <genius5711@gmail.com>
@somaz94
somaz94 force-pushed the feat/ui-skip-schema-validation branch from 8bcc993 to 842266c Compare August 11, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add validate=false to ui

1 participant