feat(ui): preserve application search bar content across navigation (#5655) - #28406
feat(ui): preserve application search bar content across navigation (#5655)#28406somaz94 wants to merge 1 commit into
Conversation
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Bundle ReportChanges will increase total bundle size by 114 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: argo-cd-ui-array-pushAssets Changed:
|
a7556ad to
8fbf53e
Compare
|
Rebased on latest The interesting part:
|
Signed-off-by: somaz <genius5711@gmail.com>
58135c5 to
da40a9f
Compare
|
Open since June with no review. This preserves the application search bar content across navigation. Is that a change you would want in the UI? Happy to close if not, otherwise it is green and ready. |
Closes #5655
What
On the Applications list page, structured filters are persisted to view
preferences (localStorage), but the free-text search bar is only kept in the
URL query string. Navigating into an app and back via in-app navigation drops
the
?search=param, so the search box comes back empty while the filterssurvive. The original issue asks for the search bar to be preserved the same
way the filters are.
Changes
searchfield toAppsListPreferences(default'', normalized on load).ApplicationsListSearchBar.onChangealongside theexisting URL update, mirroring how filters are stored.
(if present) > persisted preference > empty.
Validation
pnpm lint(tsc --noEmit + eslint): clean.pnpm test(jest): 23 suites / 266 tests pass, including 3 new tests inview-preferences-service.test.tscovering the default, a persist + reloadround-trip, and normalization of older stored preferences without
search.This is a UI-only change (the search box has no CLI equivalent).
Checklist:
good first issue,enhancement).