Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable usetesting linter #21935

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mmorel-35
Copy link
Contributor

Description

usetesting: Reports uses of functions with replacement inside the testing package.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 requested a review from a team as a code owner February 21, 2025 18:13
Copy link

bunnyshell bot commented Feb 21, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) February 21, 2025 18:29
@crenshaw-dev crenshaw-dev merged commit 37aaeb3 into argoproj:master Feb 21, 2025
26 checks passed
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.70%. Comparing base (7870200) to head (c17ce88).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21935      +/-   ##
==========================================
+ Coverage   53.83%   55.70%   +1.87%     
==========================================
  Files         341      341              
  Lines       57004    57004              
==========================================
+ Hits        30689    31755    +1066     
+ Misses      23720    22611    -1109     
- Partials     2595     2638      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 deleted the golangci-lint/usetesting branch February 21, 2025 19:04
rumstead pushed a commit to rumstead/argo-cd that referenced this pull request Feb 24, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
chzar pushed a commit to chzar/argo-cd that referenced this pull request Mar 3, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants