Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): update gitlab SCM provider to search on parent folder (#16253) (cherry-pick #21491) #21503

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix(appset): update gitlab SCM provider to search on parent folder (#16253) (#21491)

  • (fix:appset) update gitlab SCM provider to search on parent folder

fix #16253

Signed-off-by: Prune prune@lecentre.net

  • adding test-case that replicated the new Gitlab API behaviour

Signed-off-by: Prune prune@lecentre.net

  • add comments to the case

Signed-off-by: Prune prune@lecentre.net


Signed-off-by: Prune prune@lecentre.net

…16253) (#21491)

* (fix:appset) update gitlab SCM provider to search on parent folder

fix #16253

Signed-off-by: Prune <prune@lecentre.net>

* adding test-case that replicated the new Gitlab API behaviour

Signed-off-by: Prune <prune@lecentre.net>

* add comments to the case

Signed-off-by: Prune <prune@lecentre.net>

---------

Signed-off-by: Prune <prune@lecentre.net>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner January 15, 2025 18:18
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.21%. Comparing base (97704ac) to head (7018e3f).
Report is 1 commits behind head on release-2.14.

Files with missing lines Patch % Lines
applicationset/services/scm_provider/gitlab.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.14   #21503      +/-   ##
================================================
- Coverage         55.16%   53.21%   -1.96%     
================================================
  Files               338      338              
  Lines             57167    57158       -9     
================================================
- Hits              31536    30416    -1120     
- Misses            22923    24090    +1167     
+ Partials           2708     2652      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit ebf754e into release-2.14 Jan 15, 2025
22 of 25 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-08411c-release-2.14 branch January 15, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants