-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(ui): rename filter message status on SYNC STATUS view #21061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,7 +16,7 @@ interface Props { | |||
operationState: models.OperationState; | |||
} | |||
const buildResourceUniqueId = (res: Omit<models.ResourceRef, 'uid'>) => `${res.group}-${res.kind}-${res.version}-${res.namespace}-${res.name}`; | |||
const FilterableMessageStatuses = ['configured', 'unchanged']; | |||
const FilterableMessageStatuses = ['changed', 'unchanged']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these do not represent the actual text we are searching for, then perhaps we should capitalize the first letter:
['Changed', 'Unchanged']
Also, this will make it consistent with the other three existing filters.
Also, maybe we can add a tooltip like this, to explain it, and users won't get confused. ![]() Here's the code for it:
Maybe @jannfis can finalize on the wording? |
@keithchong, out of the 4, this will be the only item with a tooltip, a little bit inconsistent may be? If we add to all then that should be on a different PR? |
3e04d6f
to
9d56043
Compare
9d56043
to
86d27f9
Compare
86d27f9
to
8e90e2f
Compare
44dcce0
to
8dc66ff
Compare
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
8dc66ff
to
b823416
Compare
@aali309, I think it is fine since the others are more self-explanatory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…21061) * rename filter message status Signed-off-by: Atif Ali <atali@redhat.com> * capitalize for cosistency with other filters Signed-off-by: Atif Ali <atali@redhat.com> * added tooltip for message filter Signed-off-by: Atif Ali <atali@redhat.com> * lint fix Signed-off-by: Atif Ali <atali@redhat.com> * Trigger workflow tests Signed-off-by: Atif Ali <atali@redhat.com> --------- Signed-off-by: Atif Ali <atali@redhat.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
…21061) * rename filter message status Signed-off-by: Atif Ali <atali@redhat.com> * capitalize for cosistency with other filters Signed-off-by: Atif Ali <atali@redhat.com> * added tooltip for message filter Signed-off-by: Atif Ali <atali@redhat.com> * lint fix Signed-off-by: Atif Ali <atali@redhat.com> * Trigger workflow tests Signed-off-by: Atif Ali <atali@redhat.com> --------- Signed-off-by: Atif Ali <atali@redhat.com>
…21061) * rename filter message status Signed-off-by: Atif Ali <atali@redhat.com> * capitalize for cosistency with other filters Signed-off-by: Atif Ali <atali@redhat.com> * added tooltip for message filter Signed-off-by: Atif Ali <atali@redhat.com> * lint fix Signed-off-by: Atif Ali <atali@redhat.com> * Trigger workflow tests Signed-off-by: Atif Ali <atali@redhat.com> --------- Signed-off-by: Atif Ali <atali@redhat.com> Signed-off-by: flbla <flbla@users.noreply.github.com>
…21061) * rename filter message status Signed-off-by: Atif Ali <atali@redhat.com> * capitalize for cosistency with other filters Signed-off-by: Atif Ali <atali@redhat.com> * added tooltip for message filter Signed-off-by: Atif Ali <atali@redhat.com> * lint fix Signed-off-by: Atif Ali <atali@redhat.com> * Trigger workflow tests Signed-off-by: Atif Ali <atali@redhat.com> --------- Signed-off-by: Atif Ali <atali@redhat.com>
Original PR: #20850
Description
Rename
configured
filter tochanged
in the SYNC STATUS view to make it more self-explanatory for users. This helps users clearly distinguish between resources that were changed and those that remained untouched during sync.Changes
configured
tochanged
in FilterableMessageStatusesChecklist: