Skip to content

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Dec 4, 2024

Original PR: #20850

Description

Rename configured filter to changed in the SYNC STATUS view to make it more self-explanatory for users. This helps users clearly distinguish between resources that were changed and those that remained untouched during sync.

Changes

  • Renamed configured to changed in FilterableMessageStatuses
  • No functional changes to the filtering logic

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Copy link

bunnyshell bot commented Dec 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@aali309
Copy link
Contributor Author

aali309 commented Dec 4, 2024

Screenshot 2024-12-04 at 12 26 52 PM

@aali309 aali309 marked this pull request as ready for review December 4, 2024 18:20
@aali309 aali309 requested a review from a team as a code owner December 4, 2024 18:20
Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -16,7 +16,7 @@ interface Props {
operationState: models.OperationState;
}
const buildResourceUniqueId = (res: Omit<models.ResourceRef, 'uid'>) => `${res.group}-${res.kind}-${res.version}-${res.namespace}-${res.name}`;
const FilterableMessageStatuses = ['configured', 'unchanged'];
const FilterableMessageStatuses = ['changed', 'unchanged'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these do not represent the actual text we are searching for, then perhaps we should capitalize the first letter:
['Changed', 'Unchanged']

Also, this will make it consistent with the other three existing filters.

@keithchong
Copy link
Contributor

keithchong commented Dec 4, 2024

Also, maybe we can add a tooltip like this, to explain it, and users won't get confused.

tooltip

Here's the code for it:

<Tooltip
    placement='top-start'
    content={<div>Filter on resources that have changed or remained unchanged</div>}>
    <div>
        <Filter options={FilterableMessageStatuses} filters={messageFilters} setFilters={setMessageFilters} title='MESSAGE'/>
    </div>
</Tooltip>

Maybe @jannfis can finalize on the wording?

@aali309
Copy link
Contributor Author

aali309 commented Dec 5, 2024

Also, maybe we can add a tooltip like this, to explain it, and users won't get confused.

tooltip Here's the code for it:
<Tooltip
    placement='top-start'
    content={<div>Filter on resources that have changed or remained unchanged</div>}>
    <div>
        <Filter options={FilterableMessageStatuses} filters={messageFilters} setFilters={setMessageFilters} title='MESSAGE'/>
    </div>
</Tooltip>

Maybe @jannfis can finalize on the wording?

@keithchong, out of the 4, this will be the only item with a tooltip, a little bit inconsistent may be? If we add to all then that should be on a different PR?

@aali309 aali309 force-pushed the renameFilterMessageStatus branch 4 times, most recently from 3e04d6f to 9d56043 Compare December 11, 2024 20:14
@aali309 aali309 force-pushed the renameFilterMessageStatus branch from 9d56043 to 86d27f9 Compare December 18, 2024 20:48
@aali309 aali309 requested a review from keithchong December 19, 2024 17:52
@aali309 aali309 force-pushed the renameFilterMessageStatus branch from 86d27f9 to 8e90e2f Compare December 19, 2024 17:54
@aali309 aali309 force-pushed the renameFilterMessageStatus branch 5 times, most recently from 44dcce0 to 8dc66ff Compare January 8, 2025 21:18
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
@aali309 aali309 force-pushed the renameFilterMessageStatus branch from 8dc66ff to b823416 Compare January 8, 2025 21:57
@keithchong
Copy link
Contributor

@aali309, I think it is fine since the others are more self-explanatory.

Copy link
Contributor

@keithchong keithchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong keithchong merged commit b8508f2 into argoproj:master Jan 8, 2025
23 checks passed
@aali309 aali309 deleted the renameFilterMessageStatus branch January 15, 2025 13:14
dudo pushed a commit to dudo/argo-cd that referenced this pull request Jan 18, 2025
…21061)

* rename filter message status

Signed-off-by: Atif Ali <atali@redhat.com>

* capitalize for cosistency with other filters

Signed-off-by: Atif Ali <atali@redhat.com>

* added tooltip for message filter

Signed-off-by: Atif Ali <atali@redhat.com>

* lint fix

Signed-off-by: Atif Ali <atali@redhat.com>

* Trigger workflow tests

Signed-off-by: Atif Ali <atali@redhat.com>

---------

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Brett C. Dudo <brett@dudo.io>
revitalbarletz pushed a commit to revitalbarletz/argo-cd that referenced this pull request Jan 20, 2025
…21061)

* rename filter message status

Signed-off-by: Atif Ali <atali@redhat.com>

* capitalize for cosistency with other filters

Signed-off-by: Atif Ali <atali@redhat.com>

* added tooltip for message filter

Signed-off-by: Atif Ali <atali@redhat.com>

* lint fix

Signed-off-by: Atif Ali <atali@redhat.com>

* Trigger workflow tests

Signed-off-by: Atif Ali <atali@redhat.com>

---------

Signed-off-by: Atif Ali <atali@redhat.com>
flbla pushed a commit to flbla/argo-cd that referenced this pull request Jan 20, 2025
…21061)

* rename filter message status

Signed-off-by: Atif Ali <atali@redhat.com>

* capitalize for cosistency with other filters

Signed-off-by: Atif Ali <atali@redhat.com>

* added tooltip for message filter

Signed-off-by: Atif Ali <atali@redhat.com>

* lint fix

Signed-off-by: Atif Ali <atali@redhat.com>

* Trigger workflow tests

Signed-off-by: Atif Ali <atali@redhat.com>

---------

Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: flbla <flbla@users.noreply.github.com>
vasilegroza pushed a commit to vasilegroza/argo-cd that referenced this pull request Feb 27, 2025
…21061)

* rename filter message status

Signed-off-by: Atif Ali <atali@redhat.com>

* capitalize for cosistency with other filters

Signed-off-by: Atif Ali <atali@redhat.com>

* added tooltip for message filter

Signed-off-by: Atif Ali <atali@redhat.com>

* lint fix

Signed-off-by: Atif Ali <atali@redhat.com>

* Trigger workflow tests

Signed-off-by: Atif Ali <atali@redhat.com>

---------

Signed-off-by: Atif Ali <atali@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants