fix: order conditions summary #20759
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
mmorel-35
force-pushed
the
sorted-summary
branch
from
d6a40c6
to
895a800
Compare
|
/cc @pasha-codefresh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20759 +/- ##
==========================================
- Coverage 55.17% 55.12% -0.05%
==========================================
Files 324 324
Lines 55256 55257 +1
==========================================
- Hits 30487 30460 -27
- Misses 22156 22176 +20
- Partials 2613 2621 +8 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
sorted-summary
branch
2 times, most recently
from
7da297e
to
86d1af6
Compare
|
/cc @crenshaw-dev |
|
LGTM ! |
andrii-korotkov-verkada
approved these changes
Nov 14, 2024
mmorel-35
force-pushed
the
sorted-summary
branch
from
86d1af6
to
f5805e2
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
sorted-summary
branch
from
f5805e2
to
94adc4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatConditionsSummary doesn't have a predictable outcome.
This fixes this situation caused by https://github.com/argoproj/argo-cd/pull/20750/files#diff-09dc2060ef1815120b6ffc55153594e558691f94bd2fcd47e0e0acb8ba68066aL536-R494