feat(app): add ignore-healthcheck annotation #20462
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
CefBoud
changed the title
CefBoud
force-pushed
the
feat/add-skip-healthcheck-annotation
branch
4 times, most recently
from
a8ac772 to
a320f73
Compare
|
There may be a better way, but need more context. See comments on the issue. |
| @@ -24,6 +25,9 @@ func setApplicationHealth(resources []managedResource, statuses []appv1.Resource | |||
| if res.Target != nil && hookutil.Skip(res.Target) { | |||
| continue | |||
| } | |||
| if res.Target != nil && res.Target.GetAnnotations() != nil && res.Target.GetAnnotations()[common.AnnotationIgnoreHealthCheck] == "true" { | |||
There was a problem hiding this comment.
Are the resources here all app resources or only immediate children?
There was a problem hiding this comment.
Only immediate childre. As per documentation: An Argo CD App's health is inferred from the health of its immediate child resources
Signed-off-by: cef <moncef.abboud95@gmail.com>
CefBoud
force-pushed
the
feat/add-skip-healthcheck-annotation
branch
from
a320f73 to
c90f734
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20462 +/- ##
==========================================
- Coverage 55.17% 55.15% -0.02%
==========================================
Files 324 324
Lines 55259 55261 +2
==========================================
- Hits 30487 30479 -8
- Misses 22158 22165 +7
- Partials 2614 2617 +3 ☔ View full report in Codecov by Sentry. |
|
This is a great feature - and one I was just asking for at https://cloud-native.slack.com/archives/C01TSERG0KZ/p1733341603617349... any chance this will make it into 2.13.2? |
Signed-off-by: cef <moncef.abboud95@gmail.com> Signed-off-by: Adrian Aneci <aneci@adobe.com>
Closes #19284
Description
This PR introduces the
argocd.argoproj.io/ignore-healthcheckannotation for an Application's immediate children. This allows the health status of these child resources to be disregarded when assessing the overall health of the Application. This is particularly useful when the unhealthiness of a child resource is acceptable and should not affect the Application's health evaluation.Checklist: