Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exclude Endpoints and EndpointSlices Kubernetes resource by default #20251

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat: exclude Endpoints and EndpointSlices Kubernetes resource by default #20251

merged 2 commits into from
Oct 8, 2024

Conversation

jaehanbyun
Copy link
Contributor

@jaehanbyun jaehanbyun commented Oct 6, 2024 •
edited
Loading

Fixes #20013

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

What I have done:

  • Exclude Endpoints and EndpointSlices by default.

@jaehanbyun
feat: exclude Endpoints and EndpointSlices Kubernetes resource by def…
30c6df0 
…ault

Signed-off-by: jaehanbyun <awbrg789@naver.com>
@jaehanbyun jaehanbyun requested review from a team as code owners October 6, 2024 13:06
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 6, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 6, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

nitishfy
nitishfy approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ishitasequeira
ishitasequeira reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaehanbyun The PR looks good. Can you resolve conflicts?

@jaehanbyun
Merge branch 'master' into issue-20013
8b5e431 
Signed-off-by: 변재한 <awbrg789@naver.com>
@jaehanbyun
Copy link
Contributor Author

@ishitasequeira I've resolved the conflicts. Thank you!

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (3f249ff) to head (8b5e431).
Report is 380 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20251   +/-   ##
=======================================
  Coverage   55.95%   55.95%           
=======================================
  Files         322      322           
  Lines       44673    44673           
=======================================
  Hits        24996    24996           
- Misses      17084    17087    +3     
+ Partials     2593     2590    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdsoumya gdsoumya merged commit a288b4d into argoproj:master Oct 8, 2024
28 checks passed
@agaudreault
Copy link
Member

I think this should be reverted. The behavior of this pull request is not configurable by the users and a user that wants to display Endpoint or Endpoint Slices in the UI of Argo cannot do it anymore.

The proposal on the issue suggested to add it to the default configuration for the 3.0 version.

@crenshaw-dev
Copy link
Member

@agaudreault if you open the revert PR, I'll merge

@agaudreault agaudreault mentioned this pull request Oct 10, 2024
Merged
ali-hamza-noor pushed a commit to ali-hamza-noor/argo-cd that referenced this pull request Oct 10, 2024
@jaehanbyun @ali-hamza-noor
feat: exclude Endpoints and EndpointSlices Kubernetes resource by def…
aa5037b 
…ault (argoproj#20251)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@jaehanbyun @austin5219
feat: exclude Endpoints and EndpointSlices Kubernetes resource by def…
4790608 
…ault (argoproj#20251)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
@jaehanbyun jaehanbyun mentioned this pull request Oct 25, 2024
Closed
6 tasks
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@jaehanbyun @adriananeci
feat: exclude Endpoints and EndpointSlices Kubernetes resource by def…
c1a8d94 
…ault (argoproj#20251)

Signed-off-by: jaehanbyun <awbrg789@naver.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira left review comments

@gdsoumya gdsoumya gdsoumya approved these changes

@nitishfy nitishfy nitishfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore known Kubernetes internal resources by default with resource.exclusions
6 participants
@jaehanbyun @agaudreault @crenshaw-dev @gdsoumya @ishitasequeira @nitishfy