Issue #738 - Allow configuring google analytics tracking #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
approved these changes
Jul 1, 2019
| const token = cookies['argocd.token']; | ||
| const user: any = token && jwt(token) || null; | ||
| if (user) { | ||
| return user.email || user.sub; |
There was a problem hiding this comment.
it makes sense. changed to return 'anonymous' is there is no user
There was a problem hiding this comment.
sorry - I meant to say we should obfuscate the UID before we send it to Google
There was a problem hiding this comment.
as we agreed offline, added setting to obfuscate user ids. By default user ids are obfuscated
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
=========================================
- Coverage 35.74% 35.54% -0.2%
=========================================
Files 86 85 -1
Lines 12039 12006 -33
=========================================
- Hits 4303 4268 -35
- Misses 7149 7150 +1
- Partials 587 588 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738