Sync wave #1634
Merged
Sync wave #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
requested changes
Jun 3, 2019
| @@ -313,7 +317,7 @@ func (m *appStateManager) CompareAppState(app *v1alpha1.Application, revision st | |||
| } | |||
|
|
|||
| diffResult := diffResults.Diffs[i] | |||
| if resState.Hook { | |||
| if resState.Hook || resource.Ignore(obj) { | |||
There was a problem hiding this comment.
Please make the same change in https://github.com/alexec/argo-cd/blob/5596bd1dae964e8718bac33fca47d64f78cba44b/cmd/argocd/commands/app.go#L647
| } else { | ||
| fmt.Fprintf(w, "GROUP\tKIND\tNAMESPACE\tNAME\tSTATUS\tHEALTH\n") | ||
| } | ||
| func printAppResources(w io.Writer, app *argoappv1.Application) { |
There was a problem hiding this comment.
Looks like CLI won't print sync message any more. Can we restore this functionality?
There was a problem hiding this comment.
This was a tough one. A resource can be a hook, and a hook may have two messages (in edge cases, they can be part of two phases).
Options:
- No message.
- Only messages for non-hook resources.
- Combine multiple messages into a summary message.
Thoughts?
There was a problem hiding this comment.
I think we need to combine messages into a summary message.
alexec
requested review from
jessesuen and
alexmt
and removed request for
jessesuen
alexec
commented
Jun 4, 2019
alexec
commented
Jun 4, 2019
alexec
commented
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.