Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm set parameter to allow passing list parameters #15978

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: helm set parameter to allow passing list parameters #15978

merged 1 commit into from
Oct 16, 2023

Conversation

kkk777-7
Copy link
Contributor

Hi team,
This PR aims to fix helm set parameter for passing list parameters format.
Related bug is reported in the following Issue. #15930

Closes #15930

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@kkk777-7
fix: helm set parameter to allow passing list parameters
d914234 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@kkk777-7 kkk777-7 requested a review from a team as a code owner October 15, 2023 12:54
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0fdd534) 49.67% compared to head (d914234) 49.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15978   +/-   ##
=======================================
  Coverage   49.67%   49.67%           
=======================================
  Files         267      267           
  Lines       46383    46387    +4     
=======================================
+ Hits        23039    23043    +4     
  Misses      21084    21084           
  Partials     2260     2260
Files Coverage Δ
util/helm/cmd.go 35.21% <100.00%> (+1.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kkk777-7 , the change looks good.

@crenshaw-dev crenshaw-dev merged commit da57e03 into argoproj:master Oct 16, 2023
25 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@kkk777-7
fix: helm set parameter to allow passing list parameters (#15978)
20dff94 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 16, 2023
Merged
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@kkk777-7
fix: helm set parameter to allow passing list parameters (#15978)
cdf8f06 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 16, 2023
Merged
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@kkk777-7
fix: helm set parameter to allow passing list parameters (#15978)
a53a4c2 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
This was referenced Oct 16, 2023
Merged
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 16, 2023
@kkk777-7
fix: helm set parameter to allow passing list parameters (#15978)
1a8c593 
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 16, 2023
@gcp-cherry-pick-bot @kkk777-7
fix: helm set parameter to allow passing list parameters (#15978) (#1…
55e5d6b 
…5993)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 16, 2023
@gcp-cherry-pick-bot @kkk777-7
fix: helm set parameter to allow passing list parameters (#15978) (#1…
a9c87d2 
…5994)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 16, 2023
@gcp-cherry-pick-bot @kkk777-7
fix: helm set parameter to allow passing list parameters (#15978) (#1…
0b4d410 
…5995)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
crenshaw-dev pushed a commit that referenced this pull request Oct 16, 2023
@gcp-cherry-pick-bot @kkk777-7
fix: helm set parameter to allow passing list parameters (#15978) (#1…
975f78a 
…5996)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Co-authored-by: Kota Kimura <86363983+kkk777-7@users.noreply.github.com>
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
@kkk777-7 @ymktmk
fix: helm set parameter to allow passing list parameters (argoproj#15978
9215401 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
@kkk777-7 @jmilic1
fix: helm set parameter to allow passing list parameters (argoproj#15978
cd03d0c 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@kkk777-7 @vladfr
fix: helm set parameter to allow passing list parameters (argoproj#15978
614e555 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@kkk777-7 @tesla59
fix: helm set parameter to allow passing list parameters (argoproj#15978
72c2d8f 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
@kkk777-7 @lukaszgyg
fix: helm set parameter to allow passing list parameters (argoproj#15978
533e643 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@kkk777-7 @Hariharasuthan99
fix: helm set parameter to allow passing list parameters (argoproj#15978
d86cbd8 
)

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm.parameters.values can't expanded as a list parameter
3 participants
@kkk777-7 @crenshaw-dev @ishitasequeira