Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KompiTech GmbH to organizations using Argo CD #1402

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Add KompiTech GmbH to organizations using Argo CD #1402

merged 1 commit into from
Apr 8, 2019

Conversation

pjediny
Copy link
Contributor

@pjediny pjediny commented Apr 8, 2019

No description provided.

alexec
alexec previously requested changes Apr 8, 2019
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change - LGTM otherwise!

@codecov-io
Copy link

Codecov Report

Merging #1402 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   41.31%   41.43%   +0.11%     
==========================================
  Files          56       56              
  Lines        7965     7965              
==========================================
+ Hits         3291     3300       +9     
+ Misses       4186     4173      -13     
- Partials      488      492       +4
Impacted Files Coverage Δ
controller/appcontroller.go 32.3% <0%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9988b3d...ffd00c7. Read the comment docs.

@alexmt alexmt self-requested a review April 8, 2019 19:44
@alexmt alexmt dismissed alexec’s stale review April 8, 2019 19:45

addressed

@alexmt alexmt merged commit 1e8db87 into argoproj:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants