Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Linter #1350

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Fix Failing Linter #1350

merged 1 commit into from
Apr 2, 2019

Conversation

dthomson25
Copy link
Member

I got the following errors when I run the linter on master:

reposerver/repository/repository_test.go:255:49: composites: `*github.com/argoproj/argo-cd/pkg/apis/application/v1alpha1.KustomizeImageTag` composite literal uses unkeyed fields (govet)
	assert.Equal(t, []*argoappv1.KustomizeImageTag{{"nginx", "1.15.4"}, {"k8s.gcr.io/nginx-slim", "0.8"}}, res.Kustomize.ImageTags)
	                                               ^
util/util.go:104:10: nilness: tautological condition: non-nil != nil (govet)
		if err != nil {
		       ^
make: *** [lint] Error 1```
The following PR address these issues.

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #1350 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1350      +/-   ##
==========================================
+ Coverage    37.5%   37.51%   +<.01%     
==========================================
  Files          59       59              
  Lines        9113     9112       -1     
==========================================
  Hits         3418     3418              
+ Misses       5186     5185       -1     
  Partials      509      509
Impacted Files Coverage Δ
util/util.go 12.32% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b4683...384d129. Read the comment docs.

@dthomson25 dthomson25 merged commit 7cf3f6c into argoproj:master Apr 2, 2019
@dthomson25 dthomson25 deleted the fix-linter branch April 2, 2019 23:39
alexmt pushed a commit that referenced this pull request Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants