Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add K8s v1.26, v1.25 to CI and remove v1.22 #11957

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Jan 11, 2023

Officially supported K8s versions right now are v1.26, v1.25, v1.24 and v1.23. v1.23 EOL will be 2023-02-28

Signed-off-by: jannfis jann@mistrust.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@crenshaw-dev
Copy link
Member

@jannfis does this need to be cherry-picked?

@jannfis
Copy link
Member Author

jannfis commented Jan 11, 2023

@crenshaw-dev I think we should cherry-pick into 2.6 and 2.5 branches, yes.

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 47.29% // Head: 47.29% // No change to project coverage 👍

Coverage data is based on head (4f4af94) compared to base (913ac50).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11957   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         245      245           
  Lines       41669    41669           
=======================================
  Hits        19706    19706           
  Misses      19978    19978           
  Partials     1985     1985           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev
Copy link
Member

Not sure if this is a flake or real:

time="2023-01-11T19:24:01Z" level=info msg="../../dist/argocd app sync argocd-e2e-external/test-namespaced-sync-option-validate-false --timeout 10 --prune --plaintext --server 127.0.0.1:8088 --auth-token *** --insecure" dir= execID=84d1c
time="2023-01-11T19:24:01Z" level=debug msg="TIMESTAMP  GROUP        KIND   NAMESPACE                  NAME    STATUS   HEALTH        HOOK  MESSAGE\n2023-01-11T19:24:01+00:00   apps  Deployment  argocd-e2e--test-namespaced-sync-option-validate-false-fajfp      nginx-deployment  OutOfSync  Missing              \n\nName:               argocd-e2e-external/test-namespaced-sync-option-validate-false\nProject:            default\nServer:             [https://kubernetes.default.svc\nNamespace:](https://kubernetes.default.svc/nNamespace:)          argocd-e2e--test-namespaced-sync-option-validate-false-fajfp\nURL:                [http://127.0.0.1:8088/applications/argocd-e2e-external/test-namespaced-sync-option-validate-false\nRepo:](http://127.0.0.1:8088/applications/argocd-e2e-external/test-namespaced-sync-option-validate-false/nRepo:)               file:///tmp/argo-e2e/testdata.git\nTarget:             \nPath:               crd-validation\nSyncWindow:         Sync Allowed\nSync Policy:        <none>\nSync Status:        OutOfSync from  (8813d9d)\nHealth Status:      Missing\n\nOperation:          Sync\nSync Revision:      8813d9d7141da54ce2c32a8006afa28530f47435\nPhase:              Failed\nStart:              2023-01-11 19:24:01 +0000 UTC\nFinished:           2023-01-11 19:24:01 +0000 UTC\nDuration:           0s\nMessage:            one or more objects failed to apply, reason: Deployment in version \"v1\" cannot be handled as a Deployment: json: cannot unmarshal string into Go struct field ContainerPort.spec.template.spec.containers.ports.containerPort of type int32\n\nGROUP  KIND        NAMESPACE                                                     NAME              STATUS     HEALTH   HOOK  MESSAGE\napps   Deployment  argocd-e2e--test-namespaced-sync-option-validate-false-fajfp  nginx-deployment  OutOfSync  Missing        Deployment in version \"v1\" cannot be handled as a Deployment: json: cannot unmarshal string into Go struct field ContainerPort.spec.template.spec.containers.ports.containerPort of type int32\n" duration=732.973162ms execID=84d1c
time="2023-01-11T19:24:01Z" level=error msg="`../../dist/argocd app sync argocd-e2e-external/test-namespaced-sync-option-validate-false --timeout 10 --prune --plaintext --server 127.0.0.1:8088 --auth-token *** --insecure` failed exit status 1: time=\"2023-01-11T19:24:01Z\" level=fatal msg=\"Operation has completed with phase: Failed\"" execID=84d1c
    app_management_ns_test.go:1357: failed expectation: output does not contain 'error validating data'
--- FAIL: TestNamespacedSyncOptionValidateFalse (3.30s)

@jannfis
Copy link
Member Author

jannfis commented Jan 11, 2023

I noticed that failure locally against a 1.25.4 cluster as well, so it's probably not flaky. I was assuming a local issue, though. Now it's clear that it's not a local issue. Will dig into that.

@jannfis
Copy link
Member Author

jannfis commented Jan 11, 2023

Seems Kubernetes API has changed an error message that our end-to-end test relies upon.

@jannfis
Copy link
Member Author

jannfis commented Jan 11, 2023

I'm fixing it and will submit it as part of this PR.

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis
Copy link
Member Author

jannfis commented Jan 11, 2023

OK, so now the tests pass. I will disable the v1.22.6 from being a required and instead enable the others. Some open PRs might need rebase when they re-run the tests, but that should be fine.

@jannfis jannfis merged commit cc2a27e into argoproj:master Jan 11, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
* chore: Add K8s v1.26, v1.25 to CI and remove v1.22

Signed-off-by: jannfis <jann@mistrust.net>

* Accommodate for changed error message from K8s 1.25+

Signed-off-by: jannfis <jann@mistrust.net>

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
* chore: Add K8s v1.26, v1.25 to CI and remove v1.22

Signed-off-by: jannfis <jann@mistrust.net>

* Accommodate for changed error message from K8s 1.25+

Signed-off-by: jannfis <jann@mistrust.net>

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants