Switch to kustomize2 as default. Add argocd-ha install manifests #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
force-pushed
the
kustomize2
branch
2 times, most recently
from
12c206d to
2632b93
Compare
Codecov Report
@@ Coverage Diff @@
## master #1169 +/- ##
=========================================
Coverage ? 35.98%
=========================================
Files ? 59
Lines ? 8563
Branches ? 0
=========================================
Hits ? 3081
Misses ? 5026
Partials ? 456
Continue to review full report at Codecov.
|
jessesuen
force-pushed
the
kustomize2
branch
3 times, most recently
from
e4097fc to
69431a1
Compare
alexec
reviewed
Feb 25, 2019
| @@ -44,7 +44,8 @@ spec: | |||
| repo: "{{workflow.parameters.repo}}" | |||
| revision: "{{workflow.parameters.revision}}" | |||
| container: | |||
| image: argoproj/argo-cd-ci-builder:latest | |||
| image: argoproj/argo-cd-ci-builder:v0.12.0 | |||
There was a problem hiding this comment.
Ah yes. Because I am changing the meaning of kustomize from 1 to 2, the unit tests will fail unless I publish a new "builder image". But since the same build image is used for other branches (e.g. release-0.11) it means if everyone is using :latest, then I will break the release-0.11 branch builds. It was an eventuality that we would need to start versioning the builder images, this was the first time we needed to.
| @@ -27,3 +20,9 @@ to return `Progressing` state instead of `Healthy`. | |||
| include the fix [kubernetes/kubernetes#67570](https://github.com/kubernetes/kubernetes/pull/67570) `StatefulSet` might stay in `Progressing` state. | |||
|
|
|||
| As workaround Argo CD allows providing [health check](health.md) customization which overrides default behavior. | |||
|
|
|||
| ## I forgot the admin password, how do I reset it? | |||
alexmt
reviewed
Feb 25, 2019
docs/declarative-setup.md
Outdated
| ## Applications | ||
|
|
||
| The Application CRD is the Kubernetes resource object representing a deployed application instance | ||
| in an environment. It is defined by two key pieces of information: | ||
| * `source` reference to the desired state in git (repository, revision, path, environment) | ||
| * `destination` reference to the target cluster and namespace. | ||
|
|
||
| An example Application spec is as follows: | ||
| An minimal Application spec is as follows: |
alexmt
approved these changes
Feb 25, 2019
jessesuen
force-pushed
the
kustomize2
branch
from
69431a1 to
1b10fac
Compare
jessesuen
force-pushed
the
kustomize2
branch
from
1b10fac to
eafbd95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kustomizein the path refers to kustomize 2. likewise, assumes kustomize1 exists in path, which refers to kustomize 1