Add security.md and how to build custom repo-server from Dockerfile #1078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 37.18% 37.22% +0.03%
==========================================
Files 53 53
Lines 7683 7683
==========================================
+ Hits 2857 2860 +3
+ Misses 4400 4397 -3
Partials 426 426
Continue to review full report at Codecov.
|
|
Here is an easier view than the diff view. |
jessesuen
force-pushed
the
docs
branch
2 times, most recently
from
cb0c206 to
7884e83
Compare
| @@ -36,3 +40,31 @@ version of helm than what is bundled in Argo CD: | |||
| name: custom-tools | |||
| subPath: helm | |||
| ``` | |||
|
|
|||
| ## BYOI (build your own image) | |||
There was a problem hiding this comment.
It doesn't seem like the init container approach is any simpler since you have to build the init container.
Should we always recommend the BYOI approach?
There was a problem hiding this comment.
No because in my example, I didn't have to build my container-- I got it off the shelf. I will change the example to use something like alpine so it's obvious the advantage of that approach..
| @@ -59,3 +59,12 @@ The following policies define when the hook will be deleted. | |||
| |--------|-------------| | |||
| | `HookSucceeded` | The hook resource is deleted after the hook succeeded (e.g. Job/Workflow completed successfully). | | |||
| | `HookFailed` | The hook resource is deleted after the hook failed. | | |||
|
|
|||
| As an alternative to hook deletion policies, both Jobs and Argo Workflows support the | |||
| [`ttlSecondsAfterFinished`](https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/) | |||
There was a problem hiding this comment.
Seems like many users forget to delete workflows.
Should we set ttlSecondsAfterFinished to a long default value?
There was a problem hiding this comment.
For Argo CD v0.11, they should not forget because hooks are now visible from UI. We shouldn't choose for them.
@edlee2121 please review new security doc