Design Flaw leading to errant delete

[sethgrid]

Not sure if a design flaw is a bug, but this one should be addressed and I think is easy to fix.
In the UI, on a deploy, when you click on it, you can "sync, delete, restart". A very destructive delete is an errant click away from a restart. We just did that. Accidentally clicked delete instead of restart resulting in 10s of thousands of user facing errors before we realized and re-synced.

Fix suggestion: different color dialog box or a check box "really, I want to delete"

version v.1.5.6

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

UI makes it easy to delete accidentally when you are used to restarting. Same looking dialog box and easy to autopilot your way to a deleted cluster

To Reproduce

Go to an application deploy, click hamburger, click delete or restart. Very similar.

Expected behavior

Delete should be more scary :). Confirm check box, red, something.

Screenshots

If applicable, add screenshots to help explain your problem.

Version

version v.1.5.6

Logs

Paste any relevant application logs here.

[alexmt]

I agree. Adding to v1.9 milestone as well as #3205 (application cascade delete) .

[keithchong]

Hi @alexmt, I can have a look at this one. Maybe something like this:

[keithchong]

Or, check video:

4844-DesignFlawDeleteResource.zip

[alexmt]

@keithchong ,

I was thinking the same. First I was thinking to require a typing resource name before deletion. This might be too much, sometimes we need to delete a lot of resources. I think the prominent color is enough.

[keithchong]

We could instead use, or also use, an icon. Although there is code there in place to accommodate an icon, but the layout is a bit off. The header colour will have to be separate property.

@alexmt, what do you mean by requiring a typing resource name before deletion? You mean the user has to supply the name OR the type of the resource in a field (to confirm) and then click ok? (Just like in GitHub, when you want to delete a repo, you have to type in (key in) the name of the repo before deleting it)

[keithchong]

The title colour can be customized to be red, yellow or gray.

[keithchong]

Adding an extra field to require typing a resource name to confirm isn't that much more work. @alexmt , I could go either way on this. Let me know...