Update Argo CD library to v3.1.6 #730
Conversation
the-technat
force-pushed
the
dep/argocd-3.1
branch
from
500c42f to
42c2c71
Compare
Signed-off-by: Nathanael Liechti <technat@technat.ch>
the-technat
force-pushed
the
dep/argocd-3.1
branch
from
42c2c71 to
3206ba4
Compare
| runtime.ErrorHandlers = runtimeErrorHandlers | ||
| } | ||
|
|
||
| err := headless.MaybeStartLocalServer(ctx, opts, "", nil, nil, nil) |
There was a problem hiding this comment.
This sounds interesting that there's now a proper shutdown function for the server. I suppose this could be related to #616, but have to verify over there. For now I suggest doing a no-op to keep the current behavior.
| } | ||
| } | ||
|
|
||
| func newApplicationHealthStatus(hs *v1alpha1.AppHealthStatus) *applicationHealthStatus { |
There was a problem hiding this comment.
I'm not sure if this is the way to do it. Alternative would be to not duplicate this function and create some sort of interface as HealthStatus and AppHealthStatus contain almost the same fields. Only difference is that Message is now deprecated and that's probably the reason why they created a second type that's almost identical but haven't yet migrated to this new one in every place...
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.32.2 | ||
| k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.32.2 | ||
| k8s.io/sample-controller => k8s.io/sample-controller v0.32.2 | ||
| k8s.io/api => k8s.io/api v0.33.1 |
There was a problem hiding this comment.
Copied from the go.mod file of Argo CD
the-technat
requested review from
oboukili,
onematchfox,
blakepettersson and
mkilchhofer
as code owners
Replaces #723, #729 since v3.1.2 also fixed the error and we already test against v3.1 in CI (and tests were somehow failing when using v3.0.14).
The related code changes still need to be verified if that's the way to adapt to the changes in the library.