feat: add finalizers field #635
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakepettersson
force-pushed
the
feature/add-finalizers-field
branch
from
98d38d2 to
41a2e9e
Compare
This was referenced Apr 30, 2025
blakepettersson
force-pushed
the
feature/add-finalizers-field
branch
from
41a2e9e to
9355f54
Compare
|
This comment means that it's not as trivial as just adding the field. I don't think it's a massive hurdle, but gives some food for thought. |
blakepettersson
force-pushed
the
feature/add-finalizers-field
branch
3 times, most recently
from
0ded718 to
ec4ab16
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
Stale
blakepettersson
removed
the
Stale
Finalizers are a valid field for projects, apps and appsets. Fixes argoproj-labs#391 and argoproj-labs#404. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Add existing finalizers when updating an application * Filter out non-user configured finalizers from tf state Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
feature/add-finalizers-field
branch
from
337c85e to
e739d9a
Compare
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
Stale
|
hello |
github-actions
bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizers are a valid field for projects, apps and appsets.
Fixes #391 and #404.