fix(argocd_cluster): use cluster list api to avoid 403 issues with cluster get api at cluster read time #399
Conversation
w4rgrum
force-pushed
the
fix/argocd_cluster/issue-266-use-list-api-to-read
branch
5 times, most recently
from
d2ffd2a
to
d5d059c
Compare
…uster get api at cluster read time Signed-off-by: Hugo HARS <54102154+w4rgrum@users.noreply.github.com>
w4rgrum
force-pushed
the
fix/argocd_cluster/issue-266-use-list-api-to-read
branch
from
d5d059c
to
ca58239
Compare
|
@onematchfox PR is ready to be reviewed :) |
|
any chance to have this released as new version of the provider? This seems to be a blocker when using the provider with recent ArgoCD versions |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
... |
|
This pr is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
. |
mkilchhofer
added
the
on-hold
mkilchhofer
requested review from
oboukili,
blakepettersson,
the-technat and
mkilchhofer
as code owners
| @@ -53,6 +56,7 @@ func resourceArgoCDClusterCreate(ctx context.Context, d *schema.ResourceData, me | |||
| return errorToDiagnostics(fmt.Sprintf("failed to list existing clusters when creating cluster %s", cluster.Server), err) | |||
| } | |||
|
|
|||
| // Here we will filter ourselves on the list so that we are backward compatible for argo-cd server with version < v2.8.0 (see coment above) | |||
There was a problem hiding this comment.
Do we need backward compat to versions below 2.8? That is outside of our promise, no?
There was a problem hiding this comment.
As mentioned In my review I don't think we need that compat, but since it's already coded in a way that doesn't harm we should leave it as is so far.
This PR fixes #266
Coded it with below comment in mind, meaning it is backward compatible: #266 (comment)
Getas usual first (legacy code)PermissionDeniederror (i.e.403) the fix is triggered (in a backward compatible way for servers <v2.8, see below)In that case a call is issued to the
Listapi, reusing some code used for create cluster existence checks (that already uses thisListapi). Noe that this code is able to filter the cluster in the resulting list if not yet done by the ArgoCD server (servers filtering onListapi does not work if <v2.8, see comments in linked issue and/or in the code ccomments)Also added a non-regression test to validate a server-side deletion of the cluster triggers the fix.