Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the code more go style #60

Merged
merged 1 commit into from
Jan 4, 2024
Merged

make the code more go style #60

merged 1 commit into from
Jan 4, 2024

Conversation

izturn
Copy link
Collaborator

@izturn izturn commented Jan 4, 2024

Signed-off-by: Gang Liu gang.liu@daocloud.io

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@izturn
cleanup & simpify
f067323 
Signed-off-by: gang.liu <gang.liu@daocloud.io>
@izturn izturn self-assigned this Jan 4, 2024
@izturn izturn requested a review from wilsonwu January 4, 2024 07:56
@izturn izturn enabled auto-merge (squash) January 4, 2024 07:57
wilsonwu
wilsonwu approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@wilsonwu wilsonwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@izturn izturn merged commit 5218cd7 into main Jan 4, 2024
5 checks passed
@izturn izturn deleted the refactor/naming branch January 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonwu wilsonwu wilsonwu approved these changes

Assignees

@izturn izturn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izturn @wilsonwu