Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trafficRouting's namespace #45

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Remove trafficRouting's namespace #45

merged 2 commits into from
Dec 15, 2023

Conversation

zengchongliner
Copy link
Contributor

This configuration has been removed

@wilsonwu
Copy link
Collaborator

Follow DCO by below steps:

  1. In your local branch, run: git rebase HEAD~2 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin fix-readme

@zengchongliner
Remove trafficRouting's namespace
830a1a4 
Signed-off-by: zengchongliner <chonglin.zeng@daocloud.io>
@zengchongliner
Optimize description
2e2435a 
Signed-off-by: zengchongliner <chonglin.zeng@daocloud.io>
wilsonwu
wilsonwu approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@wilsonwu wilsonwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@wilsonwu wilsonwu merged commit e49c49b into argoproj-labs:main Dec 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonwu wilsonwu wilsonwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zengchongliner @wilsonwu