Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Image CI workflow #44

Merged
merged 20 commits into from
Dec 18, 2023
Merged

Conversation

wilsonwu
Copy link
Collaborator

No description provided.

@wilsonwu
Copy link
Collaborator Author

@zachaller I'd like to build this plugin as Docker image, it is easy to use for end users, and I tried to push the image into ghcr repo, and I got below problem:

Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/argoproj-labs/rollouts-plugin-trafficrouter-contour:v0.2.1-7-g53d9e631: unexpected status from POST request to https://ghcr.io/v2/argoproj-labs/rollouts-plugin-trafficrouter-contour/blobs/uploads/: 403 Forbidden

I am not sure this is the right place I can push image into, can you help to get a official repo that I can use? Thanks!

Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
Signed-off-by: Wilson Wu <iwilsonwu@gmail.com>
@wilsonwu wilsonwu merged commit c2ddc9c into argoproj-labs:main Dec 18, 2023
5 checks passed
@zachaller
Copy link
Collaborator

I think we would just need to reach out to argo-contributors on slack to get the initial package created via this https://github.com/orgs/argoproj-labs/packages once that is done I think you can push using GITHUB_TOKEN. Also the docker image is a neat idea. Also just as a note because I did not see directions for it you can also download via https and specify a sha as well.

@wilsonwu
Copy link
Collaborator Author

I think we would just need to reach out to argo-contributors on slack to get the initial package created via this https://github.com/orgs/argoproj-labs/packages once that is done I think you can push using GITHUB_TOKEN. Also the docker image is a neat idea. Also just as a note because I did not see directions for it you can also download via https and specify a sha as well.

Thanks Zach, got it, currently I publish the image into our company registry, I will create an issue for this to improve it more open later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants