-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Verify Weight #37
Merged
izturn
merged 6 commits into
argoproj-labs:main
from
inloco:feat/implement-verify-weight
Sep 7, 2023
Merged
Implement Verify Weight #37
izturn
merged 6 commits into
argoproj-labs:main
from
inloco:feat/implement-verify-weight
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
izturn
reviewed
Aug 29, 2023
@mvgmb ping |
mvgmb
force-pushed
the
feat/implement-verify-weight
branch
from
September 6, 2023 13:25
7bff54a
to
632f289
Compare
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
mvgmb
force-pushed
the
feat/implement-verify-weight
branch
from
September 6, 2023 13:38
632f289
to
3a3fc4a
Compare
izturn
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @mvgmb thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
The weight verification takes into account the following scenarios:
Valid HTTPProxy
When the HTTPProxy is valid and does not contain errors.
Invalid HTTProxy
When the HTTPProxy contains an error or its state is invalid.
Outdated HTTPProxy
When the HTTPProxy status'
observedGeneration
field does not match the metadata'sgeneration
field don't match. This happens when the operator is unavailable or is having issues updating the HTTPProxy.