Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multiple httpproxies #20

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

sneako
Copy link
Contributor

@sneako sneako commented Jun 16, 2023

Closes #19

Signed-off-by: Nico Piderman <nico.piderman@gmail.com>
@sneako
Copy link
Contributor Author

sneako commented Jun 16, 2023

Attached are the logs for a rollout performed in a local kind cluster with two httpproxies pointed at a single service with the following strategy:

  strategy:
    canary:
      canaryMetadata:
        labels:
          rollout: canary
      canaryService: httpbin-canary
      dynamicStableScale: true
      maxUnavailable: 1
      stableMetadata:
        labels:
          rollout: stable
      stableService: httpbin
      steps:
      - setWeight: 10
      - pause:
          duration: 10
      - setWeight: 30
      - pause:
          duration: 10
      - setWeight: 50
      - pause:
          duration: 10
      - setWeight: 100
      trafficRouting:
        plugins:
          argoproj-labs/contour:
            httpProxies:
            - httpbin
            - httpbin-2
            namespace: default

rollout.txt

Copy link
Collaborator

@izturn izturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx

@izturn izturn merged commit 70e0053 into argoproj-labs:main Jun 20, 2023
@sneako sneako deleted the multiple-httpproxies branch June 20, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle multiple HTTPProxies
2 participants