Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use namespace from Rollouts resource to avoid unauthorized access to other HTTPProxies #18

Merged
merged 1 commit into from
May 26, 2023
Merged

Use namespace from Rollouts resource to avoid unauthorized access to other HTTPProxies #18

merged 1 commit into from
May 26, 2023

Conversation

mvgmb
Copy link
Contributor

@mvgmb mvgmb commented May 16, 2023

Closes #17

@mvgmb
Use namespace from Rollouts resource to avoid unauthorized access to …
d1ff4de 
…other HTTPProxies

Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
@wilsonwu
Copy link
Collaborator

@izturn could you please help to review, thanks.

@izturn izturn self-requested a review May 26, 2023 10:40
izturn
izturn approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@izturn izturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izturn izturn merged commit 988436b into argoproj-labs:main May 26, 2023
@mvgmb mvgmb deleted the feat/remove-namespace branch June 2, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izturn izturn izturn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The plugin should only consider HTTPProxies from the same namespace as the Rollout resource
3 participants
@mvgmb @wilsonwu @izturn