Skip to content

Conversation

@dronenb
Copy link

@dronenb dronenb commented Oct 21, 2025

Description

This PR adds support for Azure China and Azure US Government

Fixes: #692, #672

Replaces: #673

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.22.7 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

The cloud names are consistent with that found in az cloud list | jq -r '.[].name':

AzureCloud
AzureChinaCloud
AzureUSGovernment
AzureGermanCloud

AzureGermanCloud was decommissioned. As such, the only three relevant clouds should now be supported. Support for Azure Stack Cloud could be a future enhancement.

I have tested this with AzureCloud and AzureChinaCloud. I do not have access to an AzureUSGovernment tenant but I see no reason why it shouldn't work.

Signed-off-by: Ben Dronen <dronenb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant