Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibmsm): Copy keys from KV types #535

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

jkayani
Copy link
Member

@jkayani jkayani commented Aug 11, 2023

Description

After #517 , AVP was not handling KV secrets correctly, leaving the KV pairs of a kv secret in the data key of the returned secret's JSON instead of extracting them for individual interpolation like before. This PR restores the original behavior.

A test case was added to verify this issue (fails on HEAD) and I've verified in an e2e test that this appears to be fix the issue

Fixes: #534

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Are you adding dependencies? If so, please run go mod tidy -compat=1.17 to ensure only the minimum is pulled in.
  • Docs have been added / updated
  • Optional. My organization is added to USERS.md.

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Other information

@jkayani jkayani requested a review from werne2j as a code owner August 11, 2023 22:08
@jkayani jkayani self-assigned this Aug 11, 2023
@craneer
Copy link

craneer commented Aug 13, 2023

Is there any idea when a new release containing this update will occure?

@codecov-commenter
Copy link

Codecov Report

Merging #535 (5ecf52a) into main (4b074c7) will increase coverage by 0.64%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   70.65%   71.29%   +0.64%     
==========================================
  Files          26       26              
  Lines        1949     1951       +2     
==========================================
+ Hits         1377     1391      +14     
+ Misses        472      460      -12     
  Partials      100      100              
Files Changed Coverage Δ
pkg/backends/ibmsecretsmanager.go 63.47% <50.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jkayani jkayani merged commit f261e31 into argoproj-labs:main Aug 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants