-
Notifications
You must be signed in to change notification settings - Fork 189
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(azure): Add tests on AzureKeyvault backend #421
Signed-off-by: Yves Galante <yves.galante@zelros.com>
- Loading branch information
1 parent
5356a8c
commit fd625b2
Showing
5 changed files
with
245 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,225 @@ | ||
| package backends_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "github.com/Azure/azure-sdk-for-go/sdk/azcore" | ||
| "github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime" | ||
| "github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets" | ||
| "github.com/argoproj-labs/argocd-vault-plugin/pkg/backends" | ||
| "reflect" | ||
| "testing" | ||
| ) | ||
|
|
||
| type mockClientProxy struct { | ||
| simulateError string | ||
| } | ||
|
|
||
| type MyError struct{} | ||
|
|
||
| func (m *MyError) Error() string { | ||
| return "boom" | ||
| } | ||
|
|
||
| func makeSecretProperties(id azsecrets.ID, enable bool) *azsecrets.SecretProperties { | ||
| return &azsecrets.SecretProperties{ | ||
| ID: &id, | ||
| Attributes: &azsecrets.SecretAttributes{ | ||
| Enabled: &enable, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func makeResponse(id azsecrets.ID, value string, err error) (azsecrets.GetSecretResponse, error) { | ||
| return azsecrets.GetSecretResponse{ | ||
| Secret: azsecrets.Secret{ | ||
| ID: &id, | ||
| Value: &value, | ||
| }, | ||
| }, err | ||
| } | ||
|
|
||
| func newAzureKeyVaultBackendMock(simulateError string) *backends.AzureKeyVault { | ||
| return &backends.AzureKeyVault{ | ||
| Credential: nil, | ||
| ClientBuilder: func(vaultURL string, credential azcore.TokenCredential, options *azsecrets.ClientOptions) (backends.AzSecretsClient, error) { | ||
| return &mockClientProxy{ | ||
| simulateError: simulateError, | ||
| }, nil | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func (c *mockClientProxy) NewListSecretPropertiesPager(options *azsecrets.ListSecretPropertiesOptions) *runtime.Pager[azsecrets.ListSecretPropertiesResponse] { | ||
| var pageCount = 0 | ||
| pager := runtime.NewPager(runtime.PagingHandler[azsecrets.ListSecretPropertiesResponse]{ | ||
| More: func(current azsecrets.ListSecretPropertiesResponse) bool { | ||
| return pageCount == 0 | ||
| }, | ||
| Fetcher: func(ctx context.Context, current *azsecrets.ListSecretPropertiesResponse) (azsecrets.ListSecretPropertiesResponse, error) { | ||
| pageCount++ | ||
| var a []*azsecrets.SecretProperties | ||
| if c.simulateError == "fetch_error" { | ||
| return azsecrets.ListSecretPropertiesResponse{}, &MyError{} | ||
| } else if c.simulateError == "get_secret_error" { | ||
| a = append(a, makeSecretProperties("https://myvaultname.vault.azure.net/keys/invalid/v2", true)) | ||
| } | ||
| a = append(a, makeSecretProperties("https://myvaultname.vault.azure.net/keys/simple/v2", true)) | ||
| a = append(a, makeSecretProperties("https://myvaultname.vault.azure.net/keys/second/v2", true)) | ||
| a = append(a, makeSecretProperties("https://myvaultname.vault.azure.net/keys/disabled/v2", false)) | ||
| return azsecrets.ListSecretPropertiesResponse{ | ||
| SecretPropertiesListResult: azsecrets.SecretPropertiesListResult{ | ||
| Value: a, | ||
| }, | ||
| }, nil | ||
| }, | ||
| }) | ||
| return pager | ||
| } | ||
|
|
||
| func (c *mockClientProxy) GetSecret(ctx context.Context, name string, version string, options *azsecrets.GetSecretOptions) (azsecrets.GetSecretResponse, error) { | ||
| if name == "simple" && (version == "" || version == "v1") { | ||
| return makeResponse("simple,v2", "a_value_v1", nil) | ||
| } else if name == "simple" && version == "v2" { | ||
| return makeResponse("simple,v2", "a_value_v2", nil) | ||
| } else if name == "second" && (version == "" || version == "v2") { | ||
| return makeResponse("simple,v2", "a_value_v2", nil) | ||
| } | ||
| return makeResponse("", "", &MyError{}) | ||
| } | ||
|
|
||
| func TestAzLogin(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var err = keyVault.Login() | ||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecret(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var data, err = keyVault.GetIndividualSecret("keyvault", "simple", "", nil) | ||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| expected := "a_value_v1" | ||
| if !reflect.DeepEqual(expected, data) { | ||
| t.Errorf("expected: %s, got: %s.", expected, data) | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretWithVersion(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var data, err = keyVault.GetIndividualSecret("keyvault", "simple", "v2", nil) | ||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| expected := "a_value_v2" | ||
| if !reflect.DeepEqual(expected, data) { | ||
| t.Errorf("expected: %s, got: %s.", expected, data) | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretWithWrongVersion(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var _, err = keyVault.GetIndividualSecret("keyvault", "simple", "v3", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretNotExist(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var _, err = keyVault.GetIndividualSecret("keyvault", "not_existing", "", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretBuilderError(t *testing.T) { | ||
| var keyVault = &backends.AzureKeyVault{ | ||
| Credential: nil, | ||
| ClientBuilder: func(vaultURL string, credential azcore.TokenCredential, options *azsecrets.ClientOptions) (backends.AzSecretsClient, error) { | ||
| return nil, &MyError{} | ||
| }, | ||
| } | ||
| var _, err = keyVault.GetIndividualSecret("keyvault", "not_existing", "", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecrets(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var res, err = keyVault.GetSecrets("keyvault", "", nil) | ||
|
|
||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| expected := map[string]interface{}{ | ||
| "simple": "a_value_v1", | ||
| "second": "a_value_v2", | ||
| } | ||
| if !reflect.DeepEqual(res, expected) { | ||
| t.Errorf("expected: %s, got: %s.", expected, res) | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretsWithError(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("fetch_error") | ||
| var _, err = keyVault.GetSecrets("keyvault", "", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretsWithErrorOnGetSecret(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("get_secret_error") | ||
| var _, err = keyVault.GetSecrets("keyvault", "", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretsBuilderError(t *testing.T) { | ||
| var keyVault = &backends.AzureKeyVault{ | ||
| Credential: nil, | ||
| ClientBuilder: func(vaultURL string, credential azcore.TokenCredential, options *azsecrets.ClientOptions) (backends.AzSecretsClient, error) { | ||
| return nil, &MyError{} | ||
| }, | ||
| } | ||
| var _, err = keyVault.GetSecrets("keyvault", "", nil) | ||
| if err == nil { | ||
| t.Fatalf("expected 1 errors but got nil") | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretsVersionV1(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var res, err = keyVault.GetSecrets("keyvault", "v1", nil) | ||
|
|
||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| expected := map[string]interface{}{ | ||
| "simple": "a_value_v1", | ||
| } | ||
| if !reflect.DeepEqual(res, expected) { | ||
| t.Errorf("expected: %s, got: %s.", expected, res) | ||
| } | ||
| } | ||
|
|
||
| func TestAzGetSecretsVersionV2(t *testing.T) { | ||
| var keyVault = newAzureKeyVaultBackendMock("") | ||
| var res, err = keyVault.GetSecrets("keyvault", "v2", nil) | ||
|
|
||
| if err != nil { | ||
| t.Fatalf("expected 0 errors but got: %s", err) | ||
| } | ||
| expected := map[string]interface{}{ | ||
| "simple": "a_value_v2", | ||
| "second": "a_value_v2", | ||
| } | ||
| if !reflect.DeepEqual(res, expected) { | ||
| t.Errorf("expected: %s, got: %s.", expected, res) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters