doc: add controller env variable examples #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
jannfis
reviewed
Sep 30, 2022
docs/reference/argocd.md
Outdated
Comment on lines
191
to
193
| configMapKeyRef: | ||
| key: controller.repo.server.timeout.seconds | ||
| name: argocd-cmd-params-cm |
There was a problem hiding this comment.
Tiny nit: I think this should be intended one level deeper.
There was a problem hiding this comment.
You are correct, I will update it
Signed-off-by: saumeya <saumeyakatyal@gmail.com>
jannfis
reviewed
Oct 7, 2022
docs/reference/argocd.md
Outdated
Comment on lines
177
to
194
| If you want to use the config map (as mentioned in the link above) to set the cmd variables, you can add the following to the CR to refer to the environment variable value | ||
|
|
||
| ``` yaml | ||
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: ArgoCD | ||
| metadata: | ||
| name: example-argocd | ||
| labels: | ||
| example: controller | ||
| spec: | ||
| controller: | ||
| env: | ||
| - name: ARGOCD_APPLICATION_CONTROLLER_REPO_SERVER_TIMEOUT_SECONDS | ||
| valueFrom: | ||
| configMapKeyRef: | ||
| key: controller.repo.server.timeout.seconds | ||
| name: argocd-cmd-params-cm | ||
| ``` |
There was a problem hiding this comment.
I think this method does not make sense in the context of the Operator. We should not advocate for it. Can you please remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saumeya saumeyakatyal@gmail.com
What type of PR is this?
/kind documentation
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: