fix: Update sso eventing logic to stop spam #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaideepr97
force-pushed
the
update-sso-event
branch
from
62294b8
to
4cef41a
Compare
jaideepr97
force-pushed
the
update-sso-event
branch
from
4cef41a
to
87bb20b
Compare
jopit
requested changes
Sep 28, 2022
controllers/argocd/sso.go
Outdated
| err := argoutil.CreateEvent(r.Client, "Warning", "Deprecated", "`.spec.SSO.Image`, `.spec.SSO.Version`, `.spec.SSO.Resources` and `.spec.SSO.VerifyTLS` are deprecated, and support will be removed in Argo CD Operator v0.6.0/OpenShift GitOps v1.9.0. Keycloak configuration can be managed through `.spec.sso.keycloak`", "DeprecationNotice", cr.ObjectMeta) | ||
| if err != nil { | ||
| return err | ||
| // Emit event warning users about deprecation notice for `.spec.dex` users if not emitted already |
There was a problem hiding this comment.
This comment should reference .spec.SSO, not .spec.dex
There was a problem hiding this comment.
updated, thanks
controllers/argoutil/resource.go
Outdated
| @@ -52,17 +52,23 @@ func CombineImageTag(img string, tag string) string { | |||
| } | |||
|
|
|||
| // CreateEvent will create a new Kubernetes Event with the given action, message, reason and involved uid. | |||
| func CreateEvent(client client.Client, eventType, action, message, reason string, meta metav1.ObjectMeta) error { | |||
| event := newEvent(meta) | |||
| func CreateEvent(client client.Client, eventType, action, message, reason string, ObjectMeta metav1.ObjectMeta, typeMeta metav1.TypeMeta) error { | |||
There was a problem hiding this comment.
I'm curious why the ObjectMeta parameter name starts with an uppercase letter?
There was a problem hiding this comment.
no particular reason
changed it, thanks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR updates the logic for SSO related field deprecations in the CR, so that single event is emitted with latest timestamp and CR association so that no. of emitted events is greatly reduced and events have more metadata stored
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #785
https://issues.redhat.com/browse/GITOPS-2230
How to test changes / Special notes to the reviewer:
.spec.dex.config: test-configkubectl get eventsagainst that namespace