fix: minor spacing issue in trigger configuration blocks notifications from being sent out #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
jaideepr97
added a commit
to jaideepr97/argocd-operator
that referenced
this pull request
Jun 24, 2022
jopit
pushed a commit
that referenced
this pull request
Jun 24, 2022
jopit
pushed a commit
that referenced
this pull request
Sep 29, 2022
* minor spacing issue in trigger configuration (#687) * fix sso deprecation event spamming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Spacing issue in the
on-sync-succeededtrigger configuration inargocd-notifications-cmthrows an invalid JSON request, which blocks notifications from being sent out on successful app sync. This PR fixes thatHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: