fix: Changing log level/format triggers reconciliation #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@reginapizza Thanks for the PR. Any chance you can add a unit test? |
|
I think this is hard to be done in a unit test. This should be an e2e test, imho. |
|
@reginapizza the test won't compile. |
jaideepr97
reviewed
Oct 5, 2021
|
@wtam2018 could you please re-review? Thanks! |
|
@reginapizza |
iam-veeramalla
changed the title
|
LGTM !! Thanks @reginapizza for your first contribution ☑️. Looking forward for many more. |
iam-veeramalla
approved these changes
Oct 14, 2021
jopit
pushed a commit
to jopit/argocd-operator
that referenced
this pull request
Nov 8, 2021
…#453) * Changing log level/format triggers reconciliation * add test case for changing log format/level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
When changing the log level or log format, the operator should change the deployment spec even if the argocd-repo-server deployment resource already exists, currently that is not happening.
Have you updated the necessary documentation?
N/A
Which issue(s) this PR fixes:
Fixes #448
How to test changes:
argocd-repo-serverdeployment's container command line:kubectl get deployment argocd-repo-server -o jsonpath='{.spec.template.spec.containers[0].command}'. Observe--loglevel infoand--logformat textcommand line parameters.ArgoCDOperand to change log level and format for the repository server:kubectl patch argocd argocd --type=merge --patch '{"spec": {"repo": {"logFormat": "json", "logLevel": "debug"}}}'argocd-repo-serverdeployment's container command line again:kubectl get deployment argocd-repo-server -o jsonpath='{.spec.template.spec.containers[0].command}'. Observe command line parameters have been changed from step 1.cc: @jannfis @jaideepr97