fix: add compute resources to init containers #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add some unit tests? |
|
@wtam2018 I've added some unit tests. |
wtam2018
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR adds compute resources to definition of several of the ArgoCD init containers. Without this, the associated pods will fail to start if ArgoCD is installed into a namespace which has resource quotas set.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #304
How to test changes / Special notes to the reviewer:
To test, define a namespace that has resource quotas set, then create an ArgoCD CR that defines compute resources for its components, and install into the namespace. All pods should start successfully.