chore(lint): update golangci-lint config and fix errors reported by golangci-lint #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olangci-lint Signed-off-by: Cheng Fang <cfang@redhat.com>
|
One e2e tested failed in the job "Build and test the operator e2d", but that seems a flaky test and also failed in some other PR.
case.go:254: failed in step 4-soureNamespace_with_wildcard
case.go:256: rolebindings.rbac.authorization.k8s.io "example-argocd_dev" not found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What does this PR do / why we need it:
This PR contains the following changes:
golangci.ymlto remove or replace deprecated linters and obsolete elements;golangci-lint has version 1.60.3 built with go1.23.0 from c2e095c on 2024-08-22T21:45:24Z;nolint:annotation to all usages of the deprecatedGrafanafield, to keep using this field without warning until this field is fully removed from argocd crd.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
https://issues.redhat.com/browse/GITOPS-5439
How to test changes / Special notes to the reviewer: