fix: allow argocd spec.image to override default image for appset controller #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troller Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
svghadi
reviewed
Aug 27, 2024
svghadi
reviewed
Aug 29, 2024
saumeya
pushed a commit
to saumeya/argocd-operator
that referenced
this pull request
Sep 4, 2024
…troller (argoproj-labs#1523) * fix: allow argocd spec.image to override default image for appset controller Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix logic Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> --------- Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
saumeya
pushed a commit
to saumeya/argocd-operator
that referenced
this pull request
Sep 4, 2024
…troller (argoproj-labs#1523) * fix: allow argocd spec.image to override default image for appset controller Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix logic Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> --------- Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Current behaviour doesnt allow image to be overriden by
argocdSpec.imagefor applicationset-controller pod, with this PR update application-set controller image can be overide with priority setdefault value < .spec.image < .spec.applicationSet.imageHave you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1517
How to test changes / Special notes to the reviewer: