feat: Support notifications in any namespace

[ArthurVardevanyan]

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

/kind chore
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Adding support for the Operator to be able to use ArgoCD in Any Namespaces with The Notification Controller

See PR: argoproj/argo-cd#15702

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Before

After

[svghadi]

Thanks @ArthurVardevanyan. I will try to get to it in next few days.

[svghadi]

Hi @ArthurVardevanyan, apologies for the delay in getting back to you. After reviewing the upstream documentation [1], I noticed a couple of things that need to be addressed to get this feature working properly:

• The --self-service-notification-enabledCLI flag is missing.
• Some additional permissions may be required [2].

You might be able to resolve these issues by running some tests. Please refer to appset in any ns PR[3] for details on permission roles and policy implementation.

[1] https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/#namespace-based-configuration
[2] argoproj/argo-cd#16153
[3] #1209

[ArthurVardevanyan]

apologies for the delay

No worries, both of these flags can also be set via ENV overrides, so we have been testing with that in the interm.

• --self-service-notification-enabled

For this first point, this technically does work without, however tenants can only use the notification controller defined globally.
A question from a flagging perspective, would you want the ability to toggle this flag independently or not?,
I updated the PR to assume the enablement of both.

For my use case it isn't a problem to have it have it enabled automatically along side the any namespace feature.

Some additional permissions may be required [2].

For the second point, as far as I could tell, ArgoCD Operator doesn't provide any RBAC for the any of the argocd in any NameSpace Features, some maybe that would be a follow up to this to get all of that rigged.

I have been defining myself:
https://github.com/ArthurVardevanyan/HomeLab/blob/main/kubernetes/argocd/apps/rbac.yaml

You might be able to resolve these issues by running some tests. Please refer to appset in any ns PR[3] for details on permission roles and policy implementation.

Will take a peak at this one.

[ArthurVardevanyan]

Testing with the env workaround:
ArthurVardevanyan/HomeLab#89

Overriding the Operator from the PR: ArthurVardevanyan/HomeLab@c8eb4e9

Manual RBAC Required:

• Application / Server / Notification
  • https://github.com/ArthurVardevanyan/HomeLab/blob/main/kubernetes/argocd/apps/rbac.yaml
• Application Controller:
  • https://github.com/ArthurVardevanyan/Analytics-for-Spotify/blob/main/kubernetes/base/application.yaml#L56-L68

Notification Test: https://github.com/ArthurVardevanyan/Analytics-for-Spotify/deployments

[svghadi]

Thanks. Allow me some time to discuss this internally on design side. I will get back to you.