Fix appset policy for argocd controller #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
Re-running known flaky test
|
|
LGTM. |
svghadi
approved these changes
Aug 22, 2024
|
/cherry-pick release-0.12 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Fix appset policy for argocd controller * Fix syntax Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
svghadi
added a commit
that referenced
this pull request
Aug 22, 2024
* Fix appset policy for argocd controller * Fix syntax --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Robert Coltheart <13191652+robertcoltheart@users.noreply.github.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
|
/cherry-pick release-0.11 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Fix appset policy for argocd controller * Fix syntax Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes: #1514
How to test changes / Special notes to the reviewer: