upgrade argo-cd version to 2.12.1

[ishitasequeira]

What type of PR is this?
/kind chore

What does this PR do / why we need it:

upgrade argo-cd version to 2.12.1

[anandf]

Update controller-gen version to 0.14.0

[saumeya]

LGTM

[svghadi]

Dockerfile also needs an update, rest all looks good. Thanks.

argocd-operator/build/util/Dockerfile

Lines 1 to 2 in 6a5b081

	# Argo CD v2.11.6
	FROM quay.io/argoproj/argocd@sha256:7f82e7eec131866c3cbd91e5035381d62bd9318269cd3d16e6e2d42ede402292 as argocd

[anandf]

Are the YAML files in https://github.com/argoproj-labs/argocd-operator/tree/master/bundle/manifests updated to take the upstream ArgoCD v2.12.1 ?

[svghadi]

Oh, yes. We also need to update the Argo CD Application, Project & ApplicationSet CRD in https://github.com/argoproj-labs/argocd-operator/tree/master/config/crd/bases. Just copy these files from upstream Argo CD source tag for new version.

[ishitasequeira]

Thanks @anandf @svghadi @saumeya for the review. It looks like there are no changes in the CRDs. Because when I replace the CRDs with 2.12.1 and execute make bundle, the CRDs revert back to it's current state. The only change I found was to how the description fields are formatted.

[anandf]

LGTM

[svghadi]

Because when I replace the CRDs with 2.12.1 and execute make bundle, the CRDs revert back to it's current state.

Interesting. I see some latest changes in Application and Appset CRD in upstream https://github.com/argoproj/argo-cd/tree/v2.12.1/manifests/crds which are not present in our copy of CRDs here: https://github.com/argoproj-labs/argocd-operator/tree/master/config/crd/bases .

[svghadi]

LGTM.. Thanks

[anandf]

I think we can remove this.

[svghadi]

Not sure how to do it. go mod tidy is adding it again even if I remove it and set to just go 1.21.

[Invincibear]

Is this ready for a new release so we can get this pushed to https://operatorhub.io/operator/argocd-operator? v0.11 is still deploying Argo CD v2.10.12, I'd like to use the newer v2.12.1 which has some bug fixes affecting my deployment.

[svghadi]

Hi @Invincibear, it will still take a few weeks to get a release out. In the meantime, you can use the .spec.image and .spec.version fields in the ArgoCD CR to specify the new image to unblock yourself. Since you mentioned that there are some bug fixes in the new images that you're interested in, you likely won't run into any issues using the new image with the old operator, as the fixes, most of the times, don't require new Argo CD CRDs.

[Invincibear]

@svghadi Thanks, that worked!